[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 17:00:46 PST 2019


arphaman marked 2 inline comments as done.
arphaman added inline comments.


================
Comment at: clang-tools-extra/clangd/ParsedAST.h:80
 
+  const LangOptions &getLangOpts() const {
+    return getASTContext().getLangOpts();
----------------
kadircet wrote:
> arphaman wrote:
> > kadircet wrote:
> > > can we introduce this helper in a new patch, while changing other occurrences in clangd?
> > Sounds good, I'll do that.
> can you also revert this change?
I precommited it in c0ee0224c4cf52bc6ba74dec88b30b850deca523


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69543/new/

https://reviews.llvm.org/D69543





More information about the cfe-commits mailing list