[PATCH] D69223: WDocumentation: Implement the \anchor.

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 11:56:49 PST 2019


Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review! I recently acquired commit access so I'll commit it after updating the unit test.



================
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+  case comments::InlineCommandComment::RenderAnchor:
+    OS << " RenderAnchor";
+    break;
----------------
gribozavr2 wrote:
> Please add a test for this one to clang/test/Index/comment-to-html-xml-conversion.cpp (search for RenderEmphasized in that file).
I already added a test to `clang/test/Index/comment-to-html-xml-conversion.cpp`. I forgot to add a test to `clang/test/AST/ast-dump-comment.cpp`, is this the file you meant?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69223/new/

https://reviews.llvm.org/D69223





More information about the cfe-commits mailing list