[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

Alexey Bader via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 4 05:39:30 PST 2019


bader marked 2 inline comments as done.
bader added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:1123
 def OpenCLPrivateAddressSpace : TypeAttr {
-  let Spellings = [Keyword<"__private">, Keyword<"private">];
+  let Spellings = [Keyword<"__private">, Keyword<"private">, Clang<"ocl_private">];
   let Documentation = [OpenCLAddressSpacePrivateDocs];
----------------
Anastasia wrote:
> We don't really use ocl prefix for opencl currently? Can it be opencl_private and etc? 
Sure. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71005/new/

https://reviews.llvm.org/D71005





More information about the cfe-commits mailing list