[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

Mon Dec 2 15:12:10 PST 2019

rnk added a comment.

In D70302#1764261 <https://reviews.llvm.org/D70302#1764261>, @johannes wrote:

> I see, apologies for the premature commit.

No problem, LLVM's code review practices are somewhat opaque.

================
Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1
+// RUN: %clang -cc1 -emit-llvm %s -o /dev/null
+
----------------
johannes wrote:
> rnk wrote:
> > It's best practice to filecheck for something, even if this used to crash.
> I guess the test should make sure that the array is constructed successfully after codegen.
> I'm unsure about the best way to test that. 
I went ahead and did it in rG536cedaecbe586ec9cf86d5102872adc27e6ea23.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70302/new/

https://reviews.llvm.org/D70302