[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

Bryan Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 28 01:19:36 PST 2019


bryanpkc created this revision.
bryanpkc added reviewers: pawosm01, gtbercea.
Herald added subscribers: cfe-commits, guansong, kristof.beyls.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.

D30644 <https://reviews.llvm.org/D30644> added OpenMP offloading to AArch64 targets, then D32035 <https://reviews.llvm.org/D32035> changed the
frontend to throw an error when offloading is requested for an unsupported
target architecture. However the latter did not include AArch64 in the list
of supported architectures, causing the following unit tests to fail:

  libomptarget :: api/omp_get_num_devices.c
  libomptarget :: mapping/pr38704.c
  libomptarget :: offloading/offloading_success.c
  libomptarget :: offloading/offloading_success.cpp


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70804

Files:
  clang/lib/Frontend/CompilerInvocation.cpp


Index: clang/lib/Frontend/CompilerInvocation.cpp
===================================================================
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -3070,7 +3070,8 @@
       llvm::Triple TT(A->getValue(i));
 
       if (TT.getArch() == llvm::Triple::UnknownArch ||
-          !(TT.getArch() == llvm::Triple::ppc ||
+          !(TT.getArch() == llvm::Triple::aarch64 ||
+            TT.getArch() == llvm::Triple::ppc ||
             TT.getArch() == llvm::Triple::ppc64 ||
             TT.getArch() == llvm::Triple::ppc64le ||
             TT.getArch() == llvm::Triple::nvptx ||


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70804.231365.patch
Type: text/x-patch
Size: 641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191128/7f1db183/attachment-0001.bin>


More information about the cfe-commits mailing list