[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 27 00:05:44 PST 2019


arsenm added a comment.

In D70424#1761298 <https://reviews.llvm.org/D70424#1761298>, @arsenm wrote:

> In D70424#1758902 <https://reviews.llvm.org/D70424#1758902>, @yaxunl wrote:
>
> > LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer when -g is specified? Should we add a test for -O3 -g?
>
>
> It’s independent for every other target. This matches the standard behavior


Also -g should not change codegen, but FP elimination would obviously be a change


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70424/new/

https://reviews.llvm.org/D70424





More information about the cfe-commits mailing list