[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

Chris Hamilton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 26 13:21:11 PST 2019


chrish_ericsson_atx added a comment.

In D70203#1760299 <https://reviews.llvm.org/D70203#1760299>, @bjope wrote:

> Hi @sammccall . 
>  Just a heads up. Looks like this might have caused: https://bugs.llvm.org/show_bug.cgi?id=44143 .


Yes indeed.  I locally reverted commit a433e714 <https://reviews.llvm.org/rGa433e7141fb3f697e6430437ee73b19076603c1b> and it resolved my issue.  It's odd, though.  The unittest Sam added is nearly identical with the reproducer I posted.  Only obvious difference I see at first blush is that my reproducer uses the same identifier for the struct name and the typedef name, whereas Sam's unittest uses a unique identifier for each.  Semantically, there is no difference, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70203/new/

https://reviews.llvm.org/D70203





More information about the cfe-commits mailing list