[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 26 01:20:09 PST 2019


ilya-biryukov added a comment.

In D70500#1758963 <https://reviews.llvm.org/D70500#1758963>, @sunfish wrote:

> If people feel using -B paths, and COMPILER_PATH, are appropriate, we can use `GetProgramPath` itself, though note that that still does have a PATH fallback.


I'm not an expert in driver code and how it should behave, but being consistent with how other tools are found definitely looks much better than special-casing a single tool.
Unless there are reasons why `wasm-opt` should be special, why not use the mechanism used by all other tools?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70500/new/

https://reviews.llvm.org/D70500





More information about the cfe-commits mailing list