[PATCH] D69298: [clangd] Define out-of-line initial apply logic

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 04:34:36 PST 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

looks good.



================
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:53
+// template keyword for templated functions.
+// FIXME: This is shared with define inline, move them to a common header once
+// we have a place for such.
----------------
this function seems trivial, I'd inline them into call sides for both define inline and outline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69298/new/

https://reviews.llvm.org/D69298





More information about the cfe-commits mailing list