[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Sorry wrote comments but forgot to hit submit :(



================
Comment at: clang/include/clang/Tooling/CompilationDatabase.h:229
+/// \return true if all @files were expanded successfully or there were none.
+bool expandResponseFiles(tooling::CompileCommand &Cmd,
+                         llvm::cl::TokenizerCallback Tokenizer);
----------------
instead of exposing this functionality and handling them in Fixed and JSON compilation databases separately,  I was rather talking about creating a new type of compilation database.

as `inferTargetAndDriverMode` or `inferMissingCompileCommands` functions does. which will take an `Inner`/`Base` compilation database, and in its `getCompileCommands` method will try to expand any rsp files.

does that make sense?

Also please implement it in a new file. (but still put the declaration into this header)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70222/new/

https://reviews.llvm.org/D70222