[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 03:11:29 PST 2019


ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1865
+    )cpp";
+  // FIXME: The last reference to cux() in body of foo should not be qualified,
+  // since there is a using directive inside the function body.
----------------
NIT: move the FIXME to the test itself, it's a little hard to find


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69033/new/

https://reviews.llvm.org/D69033





More information about the cfe-commits mailing list