[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14926-14929
+      } else if (((SemaRef.getLangOpts().OpenMP >= 50 &&
+                   DKind != OMPD_target_update) ||
+                  SemaRef.getLangOpts().OpenMP < 50) &&
+                 (AllowUnitySizeArraySection && NotUnity)) {
----------------
`SemaRef.getLangOpts().OpenMP < 50 || DKind != OMPD_target_update`


================
Comment at: clang/test/OpenMP/target_update_codegen.cpp:325-326
+  // CK5-DAG: [[PC0:%.+]] = bitcast i8** [[P0]] to [10 x i32]**
+  // CK5-DAG: store [10 x [10 x [10 x i32]]]* %marr, [10 x [10 x [10 x i32]]]** [[BPC0]]
+  // CK5-DAG: store [10 x i32]* {{.+}}, [10 x i32]** [[PC0]]
+  #pragma omp target update to(marr[2][0:2][0:2])
----------------
We still map the whole array here, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69316/new/

https://reviews.llvm.org/D69316