[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:3506
+      types::ID InputType = I.first;
+      const Arg *InputArg = I.second;
+
----------------
plotfi wrote:
> compnerd wrote:
> > structured bindings ... so much.
> I don't understand? 
C++17's structured bindings would be nice:

```
for (const auto &[Type, Arg] : Inputs)
```


================
Comment at: clang/lib/Driver/Driver.cpp:3536
+
+        llvm_unreachable(
+            "IFS Pipeline can only consist of Compile followed by IfsMerge.");
----------------
I think that `switch`ing on the `Phase` will make this more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70274/new/

https://reviews.llvm.org/D70274