[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

[MyDeveloper Day via cfe-commits]

We could resolve this using a separate TokenAnalyzer pass similar to what
we are doing here  https://reviews.llvm.org/D69764, such a  would let us
look at the last token on the previous line or the next token in the next
time to ensure we don't remove legal cases like

for(;
;
)

Adding a DoubleSemiFixer type class would allow clang-format to resolve
such issue where it see erroneous double ";;" not just were the
replacements have got confused.

I'm happy to look into that if that would resolve your issues?

On Sat, Nov 16, 2019 at 11:03 PM Jonas Toth via Phabricator via cfe-commits
<cfe-commits at lists.llvm.org> wrote:

> JonasToth added a comment.
>
> Hmm. I think this is fine, even though its not perfect.
> @aaron.ballman wdyt?
>
>
> Repository:
>   rCTE Clang Tools Extra
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D70144/new/
>
> https://reviews.llvm.org/D70144
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191117/6114b586/attachment.html>