[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

Conrad Poelman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 16 00:35:56 PST 2019


poelmanc added a subscriber: mgehre.
poelmanc added a comment.

In D69145#1715611 <https://reviews.llvm.org/D69145#1715611>, @mgehre wrote:

> Exactly due to the issue you are fixing here, we ended up disabling the complete check because we didn't want to live with the warnings it produced on -Wextra.
>  Therefore, I'm actually strongly in favor to enable the option by default.
>
> When others see that clang-tidy fixits introduce warnings (with -Wextra) or even break their build (with -Werror), they might not look into check options, but just disable the check directly.


Just pinging to see if anyone has any thoughts on moving forward with this. Thanks in advance for any feedback!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69145/new/

https://reviews.llvm.org/D69145





More information about the cfe-commits mailing list