[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 14 23:56:02 PST 2019


mclow.lists added a comment.

Sorry I'm late to the party; I've been traveling for 3+ weeks.
I would like to be reassured that the following code will not warn:

  `
  long foo = ...; // some calculation
  if (foo < std::numeric_limits<int>::min() || foo > std::numeric_limits<int>::max()) .....

This is important for systems where `sizeof(int) == sizeof(long)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69292/new/

https://reviews.llvm.org/D69292





More information about the cfe-commits mailing list