[PATCH] D70280: Remove Support/Options.h, it is unused

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 14 15:22:46 PST 2019


rnk created this revision.
rnk added a reviewer: beanz.
Herald added subscribers: cfe-commits, hiraditya, mgorny.
Herald added a reviewer: jfb.
Herald added projects: clang, LLVM.

It was added in 2014 in 732e0aa9fb84f1 with one use in Scalarizer.cpp.
That one use was then removed when porting to the new pass manager in
2018 in b6f76002d9158628e78.

While the RFC and the desire to get off of static initializers for
cl::opt all still stand, this code is now dead, and I think we should
delete this code until someone is ready to do the migration.

This change depends on a large mechanical cleanup of including
CommandLine.h, StringMap.h, and raw_ostream.h which I'll push shortly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70280

Files:
  clang/tools/clang-scan-deps/ClangScanDeps.cpp
  llvm/include/llvm/IR/LLVMContext.h
  llvm/include/llvm/Support/Options.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/DebugCounter.cpp
  llvm/lib/Support/Options.cpp
  llvm/lib/Support/Signals.cpp
  llvm/lib/Transforms/Scalar/Scalarizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70280.229420.patch
Type: text/x-patch
Size: 10063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191114/ac5d56f1/attachment.bin>


More information about the cfe-commits mailing list