[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

[Pierre Habouzit via Phabricator via cfe-commits]

MadCoder added inline comments.


================
Comment at: clang/lib/Sema/SemaExprObjC.cpp:1129
+  }
+}
+
----------------
rjmccall wrote:
> Is this a good idea to do for arbitrary diagnostics?  I feel like saying "direct" in the note when that has nothing to do with the conflict could be a little misleading.
fair enough. some of the mismatches will be because of directness so it can help in that instance but I can see how it's confusing.

fixed, and the fact that tests didn't need any updating probably proves you right ;)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69991/new/

https://reviews.llvm.org/D69991