[PATCH] D70119: Improve gen_ast_dump_json_test.py

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 14 12:25:15 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some nits. Thank you for this!



================
Comment at: clang/test/AST/gen_ast_dump_json_test.py:3
 
+from __future__ import print_function
 from collections import OrderedDict
----------------
Is this needed? I don't see anything using `print_function`.


================
Comment at: clang/test/AST/gen_ast_dump_json_test.py:11
 import re
+import tempfile
 import subprocess
----------------
Can you keep this in alphabetical order?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70119/new/

https://reviews.llvm.org/D70119





More information about the cfe-commits mailing list