[clang-tools-extra] e2369fd - [clang-include-fixer] Skip .rc files when finding symbols

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 14 10:06:05 PST 2019


Author: Reid Kleckner
Date: 2019-11-14T10:04:35-08:00
New Revision: e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691

URL: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691
DIFF: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691.diff

LOG: [clang-include-fixer] Skip .rc files when finding symbols

Summary:
For some reason CMake includes entries for .rc files, but
find-all-symbols handles them improperly.

See PR43993

Reviewers: sammccall, bkramer

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70196

Added: 
    

Modified: 
    clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py b/clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py
index 5e9dde723435..02b100bd849b 100755
--- a/clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py
+++ b/clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py
@@ -89,6 +89,9 @@ def main():
   database = json.load(open(os.path.join(build_path, db_path)))
   files = [entry['file'] for entry in database]
 
+  # Filter out .rc files on Windows. CMake includes them for some reason.
+  files = [f for f in files if not f.endswith('.rc')]
+
   max_task = args.j
   if max_task == 0:
     max_task = multiprocessing.cpu_count()


        


More information about the cfe-commits mailing list