[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 23:47:10 PST 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984
        }},
+      {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp",
+       [](HoverInfo &HI) {
----------------
could you also add a case checking references to enumconstdecl?
i.e.
```
Color x = GRE^EN;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70209/new/

https://reviews.llvm.org/D70209





More information about the cfe-commits mailing list