[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 10:31:09 PST 2019


tra added a subscriber: rnk.
tra added a comment.

Calling @rnk for Windows know-how.



================
Comment at: clang/test/SemaCUDA/deleting-dtor.cu:45-46
+
+// Only MS has diagnostic since MS requires deleting dtor is emitted when
+// vtable is emitted, even though dtor is not defined.
+namespace MSEmitDeletingDtor {
----------------
Nit: I think it should be `requires deleting dtor to be emitted` or `requires that deleting dtor is emitted`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172





More information about the cfe-commits mailing list