[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 05:58:20 PST 2019


hokein added a comment.

In D70139#1743512 <https://reviews.llvm.org/D70139#1743512>, @ilya-biryukov wrote:

> NIT: we could probably add LLVM_NODISCARD attribute to ensure the return value is always consumed?
>  Another NIT: maybe do this for all methods in the index that have the limit in their request (pretty much all of them, I guess)?


This restriction seems too strong (every caller has to handle this return value), I'd keep as it-is (consistent with the fuzzyFind API).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70139/new/

https://reviews.llvm.org/D70139





More information about the cfe-commits mailing list