[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:106
+    if (auto *ChildExpression = dyn_cast<Expr>(*i)) {
+      auto Result = hasIdDepVar(ChildExpression);
+      if (Result) {
----------------
Please don't use auto when type is not explicitly spelled in same statement or iterator.


================
Comment at: clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:129
+    if (auto *ChildExpression = dyn_cast<Expr>(*I)) {
+      auto Result = hasIdDepField(ChildExpression);
+      if (Result) {
----------------
Please don't use auto when type is not explicitly spelled in same statement or iterator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70094/new/

https://reviews.llvm.org/D70094