[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 14:47:11 PST 2019


dexonsmith marked an inline comment as done.
dexonsmith added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4236
+                                              MEnd = Loaded.end();
+       M != MEnd; ++M) {
+    ModuleFile &F = *M->Mod;
----------------
aprantl wrote:
> Could this be a range-based for?
Yes, probably.  If so, I'll do that to the existing one as a prep patch (before pushing this change), and follow the style for the new one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70056/new/

https://reviews.llvm.org/D70056





More information about the cfe-commits mailing list