[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 08:58:50 PST 2019


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst:29
+
+    Semicolon-delimited list of base class names to apply this check to.
+    By default `::std::basic_string` applies to std::string and std::wstring.
----------------
"of class names"

I don't think there's anything about base classes here.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst:30
+    Semicolon-delimited list of base class names to apply this check to.
+    By default `::std::basic_string` applies to std::string and std::wstring.
+    Set to e.g. `::std::basic_string;llvm::StringRef;QString` to perform this
----------------
Please wrap std::string and std::wstring in backtics.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69548/new/

https://reviews.llvm.org/D69548





More information about the cfe-commits mailing list