[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 05:38:17 PST 2019


MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.


================
Comment at: clang/tools/clang-format/ClangFormat.cpp:304
 
-      StringRef Line(StartBuf, (EndBuf - StartBuf) - 1);
+      Mgr.AddNewSourceBuffer(
+          MemoryBuffer::getMemBuffer(StartBuf, AssumedFileName), SMLoc());
----------------
Note to self: this can probably go outside the loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69921/new/

https://reviews.llvm.org/D69921





More information about the cfe-commits mailing list