[PATCH] D69996: [clangd] Fixes colon escaping on Windows

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 01:34:46 PST 2019


hokein added a comment.

I believe this patch fixes the issue,  but we need to update the file `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations correctly" is diverged from the actual code, although it is still passed (both `string` and `vscode.Uri` have the `toString` method unfortunately).

@lh123  do you mind doing that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69996/new/

https://reviews.llvm.org/D69996





More information about the cfe-commits mailing list