[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.

LGTM, provided that the inlines are addressed! Thanks!



================
Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:102-103
   /// system call etc.
-  bool checkPre(const CallExpr *CE, CheckerContext &C) const;
+  bool checkPre(const CallExpr *CE, const FunctionDecl *FDecl, StringRef Name,
+                CheckerContext &C) const;
 
----------------
I recall that the current thinking is preferring `CallEvent`, though leave this as-is for now, because @steakhal might already have it locally.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:105
 
   /// Add taint sources on a pre-visit.
+  bool addSourcesPre(const CallExpr *CE, const FunctionDecl *FDecl,
----------------
We might as well explain what the return value here means (and for the other functions too).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59516/new/

https://reviews.llvm.org/D59516