[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 10:39:08 PST 2019


arphaman added inline comments.


================
Comment at: clang/lib/Basic/Version.cpp:143
   llvm::raw_string_ostream OS(buf);
 #ifdef CLANG_VENDOR
   OS << CLANG_VENDOR;
----------------
arphaman wrote:
> This use of `CLANG_VENDOR` should be removed as well presumably.
Please ignore my comment. I missed the fact that this output is still needed to match the `CLANG_VENDOR` use above that's not removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69925/new/

https://reviews.llvm.org/D69925





More information about the cfe-commits mailing list