[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

UTKARSH SAXENA via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 06:46:34 PST 2019


usaxena95 added a comment.

We actually use both the name and the **source location** of the macro to calculate its ID.
I see that the subject of the patch might suggest otherwise. 
This is a trivial change which just changes the params of the function so that users don't have to carry the IdentifierInfo when we just want the name out of it.

We use `clang::index::generateUSRForMacro(StringRef MacroName, SourceLocation Loc, const SourceManager &SM, SmallVectorImpl<char> &Buf)` to generate the SymbolID.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69937/new/

https://reviews.llvm.org/D69937





More information about the cfe-commits mailing list