[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

Ehud Katz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 02:49:09 PST 2019


ekatz created this revision.
ekatz added reviewers: SouraVX, aprantl, dblaikie, JDevlieghere, uabelho, rsmith.
ekatz added a project: clang.
Herald added a subscriber: cfe-commits.

Partial revert of r372681 "Support for DWARF-5 C++ language tags".

The change introduced new external linkage languages ("C++11" and "C++14") which not supported in C++.

It also changed the definition of the existing enum to use the DWARF constants. The problem is that "LinkageSpecDeclBits.Language" (the field that reserves this enum) is actually defined as 3 bits length (bitfield), which cannot contain the new DWARF constants. Defining the enum as integer literals is more appropriate for maintaining valid values.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69935

Files:
  clang/include/clang/AST/DeclCXX.h
  clang/lib/AST/DeclPrinter.cpp
  clang/lib/AST/JSONNodeDumper.cpp
  clang/lib/AST/TextNodeDumper.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/Sema/SemaModule.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69935.228196.patch
Type: text/x-patch
Size: 4412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191107/d49e35c4/attachment.bin>


More information about the cfe-commits mailing list