[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 00:59:27 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG001968490049: [clangd] Set RetainCommentsFromSystemHeaders to true (authored by ilya-biryukov).

Changed prior to commit:
  https://reviews.llvm.org/D69928?vs=228173&id=228186#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69928/new/

https://reviews.llvm.org/D69928

Files:
  clang-tools-extra/clangd/Compiler.cpp
  clang-tools-extra/clangd/index/IndexAction.cpp


Index: clang-tools-extra/clangd/index/IndexAction.cpp
===================================================================
--- clang-tools-extra/clangd/index/IndexAction.cpp
+++ clang-tools-extra/clangd/index/IndexAction.cpp
@@ -160,6 +160,7 @@
   bool BeginInvocation(CompilerInstance &CI) override {
     // We want all comments, not just the doxygen ones.
     CI.getLangOpts().CommentOpts.ParseAllComments = true;
+    CI.getLangOpts().RetainCommentsFromSystemHeaders = true;
     // Index the whole file even if there are warnings and -Werror is set.
     // Avoids some analyses too. Set in two places as we're late to the party.
     CI.getDiagnosticOpts().IgnoreWarnings = true;
Index: clang-tools-extra/clangd/Compiler.cpp
===================================================================
--- clang-tools-extra/clangd/Compiler.cpp
+++ clang-tools-extra/clangd/Compiler.cpp
@@ -63,6 +63,7 @@
   // createInvocationFromCommandLine sets DisableFree.
   CI->getFrontendOpts().DisableFree = false;
   CI->getLangOpts()->CommentOpts.ParseAllComments = true;
+  CI->getLangOpts()->RetainCommentsFromSystemHeaders = true;
   return CI;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69928.228186.patch
Type: text/x-patch
Size: 1143 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191107/2e424210/attachment.bin>


More information about the cfe-commits mailing list