[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 15:06:06 PST 2019


ABataev added a comment.

In D69853#1734760 <https://reviews.llvm.org/D69853#1734760>, @jdoerfert wrote:

> In D69853#1734620 <https://reviews.llvm.org/D69853#1734620>, @ABataev wrote:
>
> > Again, better to split into 2 patches, one for LLVM and one for clang.
>
>
> I split the other patch, but this one cannot be split in a reasonable (=testable) manner. Splitting a patch only to have smaller diffs is not the goal.


We don't need to test it. Just split it into 2 parts, llvm and clang, nothing else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69853/new/

https://reviews.llvm.org/D69853





More information about the cfe-commits mailing list