[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 10:47:42 PST 2019


hliao added a comment.

Sam, could you review this? Even though it has no functionality issue so far, from the code sequence, once there's an `addrspacecast` is inserted, we lose the chance to set target specific attributes if any.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63020/new/

https://reviews.llvm.org/D63020





More information about the cfe-commits mailing list