[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:220
+  bool VisitOverloadExpr(OverloadExpr *E) {
+    if (!E->decls().empty())
+      return true; // handled by findExplicitReferences.
----------------
ilya-biryukov wrote:
> hokein wrote:
> > IIUC, if the decls don't have the same kind, we will not highlight it (previously, we fall back to `DependentName`).
> You're right. I don't think highlighting as dependent name is any better than not highlighting at all in that case, though.
> Therefore, I would argue it's not worth adding more code to handle this corner case (I'm not even sure it's possible in practice, it'll take quite some time to come up with examples like these)
I thought it is better to highlight it rather than not highlighting, but I agree with you, it may be not worth handling this edge case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69673/new/

https://reviews.llvm.org/D69673