[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 01:30:55 PST 2019


balazske added a comment.

So we can have only one checker to model `fread` with `eval::Call`. Why is `fread` now modeled by StreamChecker and StdLibraryFunctionsChecker (both use `eval::Call`)? These checkers look at the function from different aspects, I do not like to have one checker with both checks.

Another question: I want to extend the StreamChecker with function `freopen` that returns the passed file descriptor. We should indicate that the return value is the same as argument 2 (except if arg 2 is NULL if I understand correctly the man page). And this function can fail and return NULL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69662/new/

https://reviews.llvm.org/D69662





More information about the cfe-commits mailing list