[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 4 15:06:20 PST 2019


tra added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7689
+  // Coerce HIP pointer arguments from generic pointers to global ones.
+  llvm::Type *coerce(llvm::Type *Ty, unsigned DefaultAS,
+                     unsigned GlobalAS) const {
----------------
Now it could use a more descriptive name, too. :-)

You can now also make DefaultAS/GlobalAS into local variables as you have access to `getContext()` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69826/new/

https://reviews.llvm.org/D69826





More information about the cfe-commits mailing list