[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 4 08:16:52 PST 2019


Meinersbur added a comment.

In D69764#1732232 <https://reviews.llvm.org/D69764#1732232>, @MyDeveloperDay wrote:

> @pollydev too (a previously clang-format clean directory) will generate changes running `clang-format --const-style=west -i -n *.cpp`
>
>   ScopBuilder.cpp:74:9: warning: code should be clang-formatted [-Wclang-format-violations]
>   static int const MaxDimensionsInAccessRange = 9;
>           ^
>   ScopInfo.cpp:113:2: warning: code should be clang-formatted [-Wclang-format-violations]
>   int const polly::MaxDisjunctsInDomain = 20;
>   ....
>    ^
>   ScopInfo.cpp:118:9: warning: code should be clang-formatted [-Wclang-format-violations]
>   static int const MaxDisjunctsInContext = 4;
>


Changes in clang-format 'break' Polly regularly. When that happens, we run `ninja polly-update-format` and commit. Polly should not be a reason to not make changes in clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764





More information about the cfe-commits mailing list