[clang] 9ba1661 - [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 4 08:08:45 PST 2019


Author: Ilya Biryukov
Date: 2019-11-04T17:07:53+01:00
New Revision: 9ba16615fa07c586965b1fa2dc6e88f13fe8031d

URL: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d
DIFF: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d.diff

LOG: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

Summary:
There seems to be no evidence that having internal linkage for the function
was intentional. Since 'static' functions are normally used only in .cpp
files, using 'inline' in the header file is more appropriate.

Reviewers: Anastasia

Reviewed By: Anastasia

Subscribers: merge_guards_bot, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69242

Added: 
    

Modified: 
    clang/lib/Sema/TreeTransform.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index ad3db4e134df..8cf3722f33e8 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -4566,7 +4566,7 @@ QualType TreeTransform<Derived>::TransformDecayedType(TypeLocBuilder &TLB,
 
 /// Helper to deduce addr space of a pointee type in OpenCL mode.
 /// If the type is updated it will be overwritten in PointeeType param.
-static void deduceOpenCLPointeeAddrSpace(Sema &SemaRef, QualType &PointeeType) {
+inline void deduceOpenCLPointeeAddrSpace(Sema &SemaRef, QualType &PointeeType) {
   if (PointeeType.getAddressSpace() == LangAS::Default)
     PointeeType = SemaRef.Context.getAddrSpaceQualType(PointeeType,
                                                        LangAS::opencl_generic);


        


More information about the cfe-commits mailing list