[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

[Csaba Dabis via Phabricator via cfe-commits]

Charusso added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152
+
+          if (llvm::Error Err = Repls.add(Repl))
+            llvm_unreachable("An error occured during fix-it replacements");
----------------
zinovy.nis wrote:
> Isn't `llvm_unreacheable` too pessimistic? May be use diagnostics instead?
Good idea, thanks! I was too optimistic so `llvm_unreacheable` should never fire.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69746/new/

https://reviews.llvm.org/D69746