[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 05:20:08 PDT 2019


Eugene.Zelenko added a comment.

Please mention new option in Release Notes (in new options section, if there is no such yet, see previous release for order of sections).



================
Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.h:13
 #include "../ClangTidyCheck.h"
 
+#include <string>
----------------
Please remove empty line.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst:27
+
+    Default is ``basic_string``.
+
----------------
Please use single back-ticks for options. Same below.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69548/new/

https://reviews.llvm.org/D69548





More information about the cfe-commits mailing list