[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 28 08:57:12 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you need someone to commit this on your behalf?



================
Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:97
 
+  using clang::attr::WarnUnusedResult;
+
----------------
I'd just sink this down into the matcher itself rather than use a `using` declaration for it.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69388/new/

https://reviews.llvm.org/D69388





More information about the cfe-commits mailing list