[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 25 08:06:27 PDT 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

oops, thought I've LGTM'd it on previous cycle :D



================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:483
   bool EnableFunctionArgSnippets;
+  bool CompleteArgumentList;
 };
----------------
kadircet wrote:
> maybe rather use `GenerateSnippets`? Since this doesn't generate completions for the snippets, but rather disables generation of any snippets at all.
> 
> also I think it makes sense to document this one, because of the field just above it.
not just function, also template arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69382/new/

https://reviews.llvm.org/D69382





More information about the cfe-commits mailing list