[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 23 08:05:26 PDT 2019


ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.

Adding myself to the reviewers since I've already looked at it. Unless anyone objects.



================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219
+  // destroyed first, to ensure worker threads don't access other members.
+  llvm::Optional<ClangdServer> Server;
 };
----------------
Maybe call `Server.reset()` in destructor?
This ensures `ClangdServer` is terminated first even if the members are re-ordered later


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69329/new/

https://reviews.llvm.org/D69329





More information about the cfe-commits mailing list