[PATCH] D69298: [clangd] Define out-of-line initial apply logic

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 23 07:10:03 PDT 2019


kadircet marked 7 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1574
+  ExtraFiles["Test.cpp"] = "";
+  EXPECT_EQ(apply("void fo^o() { return; }", &EditedFiles), "void foo() ;");
+  EXPECT_THAT(EditedFiles,
----------------
hokein wrote:
> thinking more about this,  if this function is inline, we will leave an unnecessary `inline` keyword after running the code action. No need to address it in the patch, just keep in mind.
> 
> can we add more tests? e.g. template functions.
added a fixme for inline stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69298/new/

https://reviews.llvm.org/D69298





More information about the cfe-commits mailing list