[PATCH] D69338: [clangd] Collect name references in the index.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 23 05:47:09 PDT 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:633
+  Annotations Header(R"(
+    class $foo[[Foo]] {
+    public:
----------------
maybe use unnamed ranges?
having `$foo[[]]` instead of `[[]]` only hurt readability


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69338/new/

https://reviews.llvm.org/D69338





More information about the cfe-commits mailing list