[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 22 07:23:47 PDT 2019


yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:2530
   Opts.GPURelocatableDeviceCode = Args.hasArg(OPT_fgpu_rdc);
+  Opts.GPUAllowDeviceInit = Args.hasArg(OPT_fgpu_allow_device_init);
   Opts.HIPUseNewLaunchAPI = Args.hasArg(OPT_fhip_new_launch_api);
----------------
tra wrote:
> It would be useful if we could get a warning if someone attempts to use this option for CUDA compilation, where the compiler will not enable device-side init.
> 
> 
I added a warning about this option is ignored for CUDA.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69268/new/

https://reviews.llvm.org/D69268





More information about the cfe-commits mailing list