[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 19 12:45:21 PDT 2019


MyDeveloperDay added a comment.

rC373922: [clang-format] [PR27004] omits leading space for noexcept when formatting… <https://reviews.llvm.org/rC373922> was to fix https://bugs.llvm.org/show_bug.cgi?id=27004 which wasn't just related to `delete` it occurred in other cases. (operator++) and there could be other cases i guess.

I think the check for delete above the code that was added was checking for `delete` being on the left i.e.  `delete()` and `delete(x)` is not a cast  (sorry I wasn't the author for that part, so might not be correct)

However, I appreciate this patch (or any patch for that matter) that strengthens our tests in this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69164/new/

https://reviews.llvm.org/D69164





More information about the cfe-commits mailing list