[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 19 07:40:29 PDT 2019


MyDeveloperDay added a comment.

Thank you for the patch.

If you plan to continue to submit patches I think it would be worthwhile if you applied for commit access, This is not the first revision from you and we need more people who are willing to help with clang-format to fix bug and do code reviews of other peoples work.

You clearly have an interested and an understanding of how clang-format works and a desire to help make it EVEN better. It is also good to get access in order to maintain the work you do,

As the cut over to github I believe is tomorrow at the LLVM meeting it might be worth waiting until after that point to work out what the procedure to obtain access will be as I'm unclear if getting permission will be the same as outlined here

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68346/new/

https://reviews.llvm.org/D68346





More information about the cfe-commits mailing list